Bug 1979 - libbe: be_activate needs to run installgrub
: libbe: be_activate needs to run installgrub
Status: RESOLVED FIXINBUILD
Product: installer
library
: unspecified
: Other Solaris
: P1 blocker (vote)
: in-preview
Assigned To: evan.layton
:
:
:
:
:
: 2413 2745
  Show dependency treegraph
 
Reported: 2008-05-19 10:20 UTC by Ethan Quach
Modified: 2008-11-24 12:49 UTC (History)
5 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Ethan Quach 2008-05-19 10:20:34 UTC
When activating an alternate BE, be_activate needs to make sure to
install the grub loader from the BE being activated.
Comment 1 Dave Miner 2008-05-19 14:06:18 UTC
I'm concerned that we need to be pretty careful here - I don't think you want
every beadm activate to result in a GRUB change, as a downgrade might render
some of the BE's unbootable.
Comment 2 Ethan Quach 2008-05-19 14:21:45 UTC
(In reply to comment #1)

Yes, you're right.  But we do need to make sure that the latest
grub loader is what's installed.  I'm not quite certain how we're
going to track this yet though.
Comment 3 David Comay 2008-06-25 13:32:20 UTC
*** Bug 2180 has been marked as a duplicate of this bug. ***
Comment 4 evan.layton 2008-07-31 09:51:12 UTC
To fix this we're adding code that checks for the existence of the capability
file for grub. If that file is not found in the BE we're activating we don't
run installgrub. If that file is found but doesn't exist in the current BE we
do run installgrub. If the capability file exists in both BEs then we check the
version and if the BE we're activating has a newer version we run installgrub.

Also since we're running this on a zpool that may be mirrored we need to go
through the vdev tree in ZFS and run installgrub for each device in the mirror.
Comment 5 evan.layton 2008-07-31 13:55:17 UTC
*** Bug 2304 has been marked as a duplicate of this bug. ***
Comment 6 evan.layton 2008-08-07 23:18:52 UTC
Fixed in changeset c0a8976c4f8dfa9066f8bf101af5944c358d2348