Bug 2793 - gnome-session-01-gnome-atom.diff fails to apply to gnome-session-2.23.6
: gnome-session-01-gnome-atom.diff fails to apply to gnome-session-2.23.6
Status: RESOLVED FIXED
Product: opensolaris
desktop
: unspecified
: ANY/Generic Solaris
: P2 major (vote)
: ---
Assigned To: Watcher account for desktop bugs
: Watcher account for desktop bugs
:
:
:
:
: 2267
  Show dependency treegraph
 
Reported: 2008-08-05 09:10 UTC by Damien Carbery
Modified: 2008-08-13 11:02 UTC (History)
4 users (show)

See Also:


Attachments
patches/gnome-session-01-gnome-atom.diff (875 bytes, patch)
2008-08-08 04:48 UTC, Ghee Teo
no flags Details | Diff
patches/gnome-session-02-gnome-about.diff (1.26 KB, patch)
2008-08-08 04:48 UTC, Ghee Teo
no flags Details | Diff
patches/gnome-session-03-wait-for-postrun.diff (2.35 KB, patch)
2008-08-08 04:49 UTC, Ghee Teo
no flags Details | Diff
patches/gnome-session-10-logout-dialog.diff (9.52 KB, patch)
2008-08-08 04:49 UTC, Ghee Teo
no flags Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description Damien Carbery 2008-08-05 09:10:31 UTC
gnome-session-01-gnome-atom.diff fails to apply to gnome-session-2.23.6
Comment 1 Damien Carbery 2008-08-05 09:13:18 UTC
It fails right from the start:

pkgbuild: + echo 'Patch #1 (gnome-session-01-gnome-atom.diff):'
pkgbuild: Patch #1 (gnome-session-01-gnome-atom.diff):
pkgbuild: + /usr/bin/gpatch --fuzz=0 --unified -p 1
pkgbuild: patching file gnome-session/main.c
pkgbuild: Hunk #1 FAILED at 15.
pkgbuild: Hunk #2 FAILED at 92.
pkgbuild: Hunk #3 FAILED at 118.
pkgbuild: 3 out of 3 hunks FAILED -- saving rejects to file
gnome-session/main.c.rej

The spec file has not been bumped.
Comment 2 Harry Lu 2008-08-05 18:10:09 UTC
CC patch owner Ghee.
Comment 3 Ghee Teo 2008-08-06 09:15:08 UTC
Fixed the patch and now the following still need to be patched:

-04- (Erwann, those it is  not applied anyway, can it be removed?)
-05- (Erwann, do not apply)
-07- (Erwann, partially applied)
-08-(Erwannm do not apply)
-09- (Brian, no longer required can be removed)
-10- (Simon, partially applied)
-11- (Ghee/Stepen, partially applied)
Comment 4 Ghee Teo 2008-08-08 04:48:13 UTC
Created an attachment (id=398) [details]
patches/gnome-session-01-gnome-atom.diff
Comment 5 Ghee Teo 2008-08-08 04:48:45 UTC
Created an attachment (id=399) [details]
patches/gnome-session-02-gnome-about.diff
Comment 6 Ghee Teo 2008-08-08 04:49:17 UTC
Created an attachment (id=400) [details]
patches/gnome-session-03-wait-for-postrun.diff
Comment 7 Ghee Teo 2008-08-08 04:49:44 UTC
Created an attachment (id=401) [details]
patches/gnome-session-10-logout-dialog.diff
Comment 8 Ghee Teo 2008-08-08 04:50:52 UTC
Since we are still awaiting a number of patches to be reworked.
So now I am attaching patches that have been reworked and revert back version
of gnome-session tarball from 2.23.6 to 2.23.5 which does contain patches that
worked.

Attached are reworked patches for 2.23.6:
patches/gnome-session-01-gnome-atom.diff
patches/gnome-session-02-gnome-about.diff
patches/gnome-session-03-wait-for-postrun.diff
patches/gnome-session-10-logout-dialog.diff
Comment 9 Ghee Teo 2008-08-13 09:09:18 UTC
Erwann has ported all his patches.
I have tried out the other commented out patches, the only one that does not
applied is 
patches/gnome-session-11-trusted-extensions.diff

I am working on it.
Comment 10 Ghee Teo 2008-08-13 11:02:11 UTC
All patches now reworked renumbered.