Bug 4481 - terminator keeps prepending "Terminator:" to title bar
: terminator keeps prepending "Terminator:" to title bar
Status: CAUSEKNOWN
Product: opensolaris
desktop
: unspecified
: Other Solaris
: P4 minor (vote)
: ---
Assigned To: Watcher account for desktop bugs
: Watcher account for desktop bugs
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-11-03 10:59 UTC by Stephen Hahn
Modified: 2009-07-13 16:49 UTC (History)
1 user (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Stephen Hahn 2008-11-03 10:59:54 UTC
I haven't figured out which events trigger it, but if you split windows in
terminator and run for a while with terminal applications that manipulate the
title bar, terminator will keep prepending (or inserting) "Terminator:" to
the title bar string.  So one's terminator title bar looks like

Terminator: Terminator: Terminator: Terminator: ...

A screenshot will be attached shortly.
Comment 1 Stephen Hahn 2008-11-11 10:30:14 UTC
Since vte.get_window_title() returns the entire string, the code in
terminatorterm.py isn't correcting its own prepending of "Terminator:".
The following gets one of these--at the cost of not reporting the application
name--but there might be another

$ diff -u terminatorterm.py.org terminatorterm.py 
--- terminatorterm.py.org    Mon Jul  7 15:03:45 2008
+++ terminatorterm.py    Tue Nov 11 10:07:57 2008
@@ -896,7 +896,7 @@
       vte.set_property ("tooltip-text", vte.get_window_title ())
     #set the title anyhow, titlebars setting only show/hide the label
     self._title.set_text(vte.get_window_title ())
-    self.terminator.set_window_title("%s: %s" %(APP_NAME.capitalize(),
vte.get_window_title ()))
+    self.terminator.set_window_title("%s" % vte.get_window_title ())
     notebookpage = self.terminator.get_first_notebook_page(vte)
     while notebookpage != None:
       if notebookpage[0].get_tab_label(notebookpage[1]):
Comment 2 Chris Jones 2009-06-30 06:42:45 UTC
This bug is being tracked upstream at
https://bugs.launchpad.net/terminator/+bug/393668

I want to do a little more investigation to see if I can make vte give us the
title the shell set, but failing that I will go for a solution like the one you
suggested. Thanks!
Comment 3 Chris Jones 2009-07-13 16:49:17 UTC
I've just committed a fix upstream which does basically exactly what you
proposed :)