Bug 5390 - SUNWsmbskr should be installed when SUNWsmbs is installed
: SUNWsmbskr should be installed when SUNWsmbs is installed
Status: CLOSED FIXINSOURCE
Product: opensolaris
packaging
: 200811
: Other Other
: P2 major (vote)
: ---
Assigned To: Rich Burridge
: osol/packaging watcher
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-11-25 04:34 UTC by Darren J Moffat
Modified: 2008-12-01 07:33 UTC (History)
3 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Darren J Moffat 2008-11-25 04:34:25 UTC
The CIFS/SMB *server* on Nevada SRV4 builds is made up from 3 packages:
   SUNWsmbsu, SUNWsmbsr, SUNWsmbskr

SUNWsmbsu and SUNWsmbsr have been combined into SUNWsmbs, but SUNWsmbskr is
missing.

This leads to very difficult to diagnose problem with the
svc:/network/smb/server service going into maintenance.

This bug doesn't appear in SX:CE because SUNWsmbsr has a dependency on
SUNWsmbskr.

To reproduce this install 2008.11 rc1b fresh and then 'pkg install SUNWsmbs'.

I don't know if this still exists in later builds because I've now upgraded to
rc2 via 'image-update'.
Comment 1 David Comay 2008-11-25 08:29:55 UTC
Recategorizing.
Comment 2 Rich Burridge 2008-11-25 08:54:36 UTC
I just tried this. I made the following change:

diff -r 2a3ba8f94ec3 src/util/distro-import/76/common/SUNWsmbs
--- a/src/util/distro-import/76/common/SUNWsmbs    Mon Nov 24 19:31:01 2008
-0600
+++ b/src/util/distro-import/76/common/SUNWsmbs    Tue Nov 25 08:50:56 2008
-0800
@@ -2,4 +2,5 @@
 classification "System/File System"
 import SUNWsmbsu
 import SUNWsmbsr
+import SUNWsmbskr
 end package

and then tried publishing the new SUNWsmbs package to a local IPS
repository on my machine (Ultra 40).

I got the following: 

...
Package 'SUNWsmbs'
  Version: 0.5.11-0.101
  Description: SMB Server
  Classification:  org.opensolaris.category.2008:System/File System
Conflict in path kernel/drv/amd64/smbsrv: IPS SUNWsmbskr SVR4 SUNWsmbskr from
/export/home/pkg-solaris/WOS_Packages/x/101a/Solaris_11/Product//SUNWsmbskr
with IPS SUNWsmbs SVR4 SUNWsmbskr from
/export/home/pkg-solaris/WOS_Packages/x/101a/Solaris_11/Product//SUNWsmbskr
Traceback (most recent call last):
  File "./solaris.py", line 1159, in ?
    SolarisParse(mf)
  File "./solaris.py", line 1064, in SolarisParse
    curpkg.import_pkg(package_name, line)
  File "./solaris.py", line 113, in import_pkg
    raise RuntimeError, s
RuntimeError: Conflict in path kernel/drv/amd64/smbsrv: IPS SUNWsmbskr SVR4
SUNWsmbskr from
/export/home/pkg-solaris/WOS_Packages/x/101a/Solaris_11/Product//SUNWsmbskr
with IPS SUNWsmbs SVR4 SUNWsmbskr from
/export/home/pkg-solaris/WOS_Packages/x/101a/Solaris_11/Product//SUNWsmbskr
*** Error code 1
make: Fatal error: Command failed for target `redist_import'
Comment 3 Danek Duvall 2008-11-25 09:14:33 UTC
That's because there's already an IPS package SUNWsmbskr.  If you're going to
be importing its bits into another package, then the other package needs to be
obsoleted.  Alternatively, you could do this via a dependency.
Comment 4 Rich Burridge 2008-11-25 11:15:46 UTC
Yes, this should have been a dependency.
Webrev and code review request to follow.

Thanks.
Comment 5 Rich Burridge 2008-11-25 13:57:40 UTC
Fix generated, webrev created and copied to cr.opensolaris.org
and request for review posted. 

See:
http://mail.opensolaris.org/pipermail/pkg-discuss/2008-November/008973.html

Changing status to FIXINPROGRESS.
Comment 6 Rich Burridge 2008-12-01 07:33:07 UTC
Latest patch viewed by Danek and David.
Fixed in changeset 5b085f82c25f7634ecf59785ada5f7115f61a764