Bug 7922 - Add pagintation to review and build pages
: Add pagintation to review and build pages
Status: VERIFIED FIXED
Product: sourcejuicer
general
: unspecified
: Other Solaris
: P1 minor
: ---
Assigned To: os-tools
: os-tools
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-04-03 03:51 UTC by Brian Nitz
Modified: 2009-05-06 08:27 UTC (History)
4 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Brian Nitz 2009-04-03 03:51:02 UTC
Review and build status pages can easily fill with too many entries to
conveniently fit on a page.  When too many entries are in the build and review
tables, the display of these tables should be split across multiple pages.
Comment 1 Andras Barna (sartek) 2009-04-07 03:27:58 UTC
this is not implemented correctly!

it should be split based on the build number imho!
Comment 2 Dermot 2009-04-07 04:19:12 UTC
Andras - yes I had to partially back out some of the changes as there
were problems with the column sorting, so I agree it's definitely
not completed.

When you say "it should be split based on the build number" do you
mean that the build status page should be ordered by the "Job ID"
field (rather than "Status")?  If so, I agree and will try to get
this fixed quickly.
Comment 3 Andras Barna (sartek) 2009-04-07 04:24:51 UTC
yes, sorry, i meant job id
Comment 4 Brian Nitz 2009-04-20 03:05:41 UTC
I need more information here.  Can you attach screenshots or give a more
detailed description of which pages are broken and how jobs should be organized
vs how they are organized?  I don't think some of these pages ever worked so I
was working in the dark to sort and organize them properly.
Comment 5 Dermot 2009-04-20 03:38:15 UTC
Brian - 
The default ordering on the "build" page seems to be the Status
field (with FAILED first, then PASSED, but with the first PASSED
jobs appearing at the top of page 2, instead of the bottom):
http://jucr.opensolaris.org/build/status/

This should be changed to order by Job Id, reversed, ie most recent
jobs appears at the top of the list.
Comment 6 Brian Nitz 2009-04-20 04:20:43 UTC
Thanks, if this is all that was wrong, it looks like an easy fix.  But it
appears that my sort column code was removed from jucr and this bug still
exists on jucr.  Is there another reason why the column sort code wasn't
deployed?
Comment 7 Dermot 2009-04-20 06:51:26 UTC
Brian, Kevin logged 7933 after testing the latest version of column sorting.
Comment 8 Brian Nitz 2009-04-27 06:57:33 UTC
Sort and pagination if fixed on the review pages.
Pagination works on the build status page but without sort.
Sort works on the myjucr page but without pagination.

I haven't found a way to allow sort, pagination and grouping to work together
in a way that is intuitive to the user, so I'm tracking the lack of
sort+paination+grougping in build status and myjucr pages in bug 8462 and
closing this bug.