Bug 8383 - nwam should be able to manage vnic, vlan, and aggr links
: nwam should be able to manage vnic, vlan, and aggr links
Status: ACCEPTED
Product: nwam
ON daemon
: unspecified
: ANY/Generic All
: P2 enhancement (vote)
: ---
Assigned To: NWAM Project
: NWAM Project
:
: nwam1-build:2009-04-20
:
:
:
  Show dependency treegraph
 
Reported: 2009-04-23 10:53 UTC by Renee Danson Sommerfeld
Modified: 2009-05-04 14:40 UTC (History)
2 users (show)

See Also:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description Renee Danson Sommerfeld 2009-04-23 10:53:27 UTC
As of the 3/31 bits, if vnics were present when nwamd started up, it found
them; that's no longer the case with the 4/20 bits.  They are reported as
a different DL_* type, but nwamd should probably just accept them and treat
them like physical links.
Comment 1 Anurag S. Maskey 2009-04-24 07:42:44 UTC
The dladm_walk() done when NWAM starts up and generates the events to create
the NCUs only walked the physical links:

    (void) dladm_walk(ncu_create_link_action_event, dld_handle, NULL,
        DATALINK_CLASS_PHYS, DATALINK_ANY_MEDIATYPE, DLADM_OPT_ACTIVE);

Changing the walk to include VNICs creates the NCUs for the VNICs:

    (void) dladm_walk(ncu_create_link_action_event, dld_handle, NULL,
        DATALINK_CLASS_PHYS | DATALINK_CLASS_VNIC, DATALINK_ANY_MEDIATYPE,
        DLADM_OPT_ACTIVE);

The VNIC NCUs are created only when NWAM (re)starts.  No events are received by
NWAM when the VNICs are actually created with NWAM running.
Comment 2 Michael Hunter 2009-04-28 22:10:42 UTC
We understand why vnics are not discovered on start but we havn't discovered
why/how we discover them when they are created after start. I think we should
either see them and deal with them correctly or not at all.  So at the moment I
think vnic support of any type should be a post integration RFE.
Comment 3 Renee Danson Sommerfeld 2009-05-04 14:40:55 UTC
In addition to the concern Michael raised about not being able to recognize
vnics when they are initially created (because a sysevent is not created,
as is the case when a physical device is inserted), I'm also concerned about
setting precedent for the way nwam manages vnics before we've fully thought
it through.  One obvious issue is that vnics are tied to underlying physical
links; if nwam treats them simply as physical links, we don't have a way of
tracking that relationship.

However, there is also a concern that if nwam's start method simply creates
vnics (with the 'dladm up-vnic' call), but nwamd itself does not manage vnics,
how will users create persistent vnic configuration?

For now, the proposed solution will be user-created ENMs which can be
automatically activated by nwam, and can create the desired vnic configuration.
More general support for vnics, vlans, and aggrs will be added to nwam in the
future.  I'm changing this to an RFE to track that work.