Bug 8788 – Markup "Error:" stays in English in translated error messages on Users panel

Bug 8788 - Markup "Error:" stays in English in translated error messages on Users panel


Summary:	Markup "Error:" stays in English in translated error messages on Users panel

Status:	ACCEPTED

Product:	installer
Component:	gui
Version:	unspecified
Platform:	ANY/Generic OpenSolaris

Importance:	P3 minor (vote)
Target Milestone:	2010.1H
Assigned To:	Kristyna Kitzbergerova
QA Contact:

URL:
Whiteboard:	reviewed-2009.06 software-l10n
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-05-07 18:58 UTC by Takeshi Asano
Modified:	2009-10-23 17:49 UTC (History)
CC List:	5 users (show)

See Also:

Attachments
Sample fix in users-screen.c (2.47 KB, patch) 2009-05-07 18:58 UTC, Takeshi Asano	no flags	Details \| Diff
ja gui-install.mo to verify the fix with (57.24 KB, application/octet-stream) 2009-05-07 19:03 UTC, Takeshi Asano	no flags	Details
'error' still in english (78.86 KB, image/png) 2009-10-15 15:25 UTC, Kristyna Kitzbergerova	no flags	Details
"Error" is still unlocalized in root login password mismatch prompt (here using traditional Chinese) (226.52 KB, image/png) 2009-10-20 17:56 UTC, Clay Baenziger	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description Takeshi Asano 2009-05-07 18:58:36 UTC

Created an attachment (id=1895) [details]
Sample fix in users-screen.c

Error messages displayed on the Users panel like:
Error: Passwords do not match.
are translated but the markup "Error:" is always in English.

Sample fix (diff of users-screen.c) is attached. Points are:
- Apply N_() when initializing PasswordErrorMarkup
- Apply _() when using PasswordErrorMarkup

Comment 1 Takeshi Asano 2009-05-07 19:03:55 UTC

Created an attachment (id=1896) [details]
ja gui-install.mo to verify the fix with

To verification of the i18n fix, replace
/usr/share/locale/ja/LC_MESSAGES/gui-install.mo
with the attached one and run the fixed gui-install.mo
with LC_ALL=ja_JP.UTF-8.

If you want to have .mo in other language to test the fix with,
please let me know.

Comment 2 Matt Keenan 2009-08-05 09:41:51 UTC

Implementing suggested fix of N_() and _() wrapping of string.

Code review submitted.

Comment 3 Matt Keenan 2009-08-06 12:08:50 UTC

Committed As revision : 4c8dca791a2294dbf9822e78597f955efd79e843

Comment 4 Kristyna Kitzbergerova 2009-10-15 15:25:44 UTC

Created an attachment (id=2825) [details]
'error' still in english

I can't confirm this on build 124, 'error' still in english (see attachment)
--> reopened

Comment 5 Clay Baenziger 2009-10-20 17:56:12 UTC

Created an attachment (id=2863) [details]
Error